RFR: 8332112: Update nsk.share.Log to don't be Finalizable

Leonid Mesnik lmesnik at openjdk.org
Sun May 12 21:38:32 UTC 2024


The nsk.share.Log doing some cleanup and reporting errors in the cleanup method. This method is supposed to be executed by finalizer originally. However, now it is called only during shutdown hook. 
The cleanup using Cleaner doesn't work. See https://bugs.openjdk.org/browse/JDK-8330760

The cleanup method flush stream and print summary which should be already printed by complain method.

This cleanup is not necessary and printing summary usually is just disabled. It is enabled if the test called 'complain' method. However, the error should have been printed already in this method.

Note: The 'verboseOnErrorEnabled' is just not used.

See isVerboseOnErrorEnabled.
    public boolean isVerboseOnErrorEnabled() {
- return errorsSummaryEnabled;
- }

-------------

Commit messages:
 - revertdc removal
 - 8332112: Update nsk.share.Log to don't be Finalizable

Changes: https://git.openjdk.org/jdk/pull/19209/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19209&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8332112
  Stats: 141 lines in 30 files changed: 2 ins; 131 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/19209.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19209/head:pull/19209

PR: https://git.openjdk.org/jdk/pull/19209


More information about the serviceability-dev mailing list