RFR: 8332042: Move MEMFLAGS to its own include file [v2]

Thomas Stuefe stuefe at openjdk.org
Tue May 14 07:19:32 UTC 2024


On Mon, 13 May 2024 10:17:57 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update mallocLimit.hpp
>
> Changes requested by stefank (Reviewer).

@stefank New version, hopefully addressed all your remarks. Thanks!

> src/hotspot/share/nmt/memflags.cpp line 27:
> 
>> 25: #include "precompiled.hpp"
>> 26: 
>> 27: #include "nmt/memflags.hpp"
> 
> There should be no blankline between precompiled.hpp and the rest of the includes.

I removed the file.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19172#issuecomment-2109454676
PR Review Comment: https://git.openjdk.org/jdk/pull/19172#discussion_r1599498716


More information about the serviceability-dev mailing list