Integrated: 8332042: Move MEMFLAGS to its own include file
Thomas Stuefe
stuefe at openjdk.org
Tue May 14 15:02:12 UTC 2024
On Fri, 10 May 2024 09:06:08 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> MEMFLAGS, as well as its enum constants, should live in its own include.
>
> The constants are used throughout the code base, often without needing the allocation APIs exposed through allocation.hpp.
>
> The MEMFLAGS enum def is often needed within NMT itself, again often without needing allocation.hpp.
>
> ---
>
> This patch moves the enum to its new file.
>
> It fixes those `allocation.hpp` includes that where only needed to get MEMFLAGS. It does not fix other includes.
>
> For backward compatibility, until we straightened out the dependencies (e.g., fixing all places where we rely on indirect includes), I added memflags.hpp to allocation.hpp.
>
> I tested (built) on:
> - MacOS aarch64, no precompiled headers, fastdebug
> - Linux x64, no precompiled headers, fastdebug, release, fastdebug crossbuild to aarch64, fastdebug minimal
This pull request has now been integrated.
Changeset: 95a60131
Author: Thomas Stuefe <stuefe at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/95a601316de06b4b0fbf6e3c7777be5d2a1ca978
Stats: 201 lines in 25 files changed: 99 ins; 66 del; 36 mod
8332042: Move MEMFLAGS to its own include file
Reviewed-by: jsjolen, stefank
-------------
PR: https://git.openjdk.org/jdk/pull/19172
More information about the serviceability-dev
mailing list