Integrated: 8332112: Update nsk.share.Log to don't print summary during VM shutdown hook

Leonid Mesnik lmesnik at openjdk.org
Wed May 15 15:00:19 UTC 2024


On Sun, 12 May 2024 21:34:41 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> The nsk.share.Log doing some cleanup and reporting errors in the cleanup method. This method is supposed to be executed by finalizer originally. However, now it is called only during shutdown hook. 
> The cleanup using Cleaner doesn't work. See https://bugs.openjdk.org/browse/JDK-8330760
> 
> The cleanup() method flush stream and print summary which should be already printed by complain method.
> 
> This cleanup is not necessary and printing summary usually is just disabled. It is enabled if the test called 'complain' method. However, the error should have been printed already in this method.
> 
> So it would be simple to remove this cleanup and reduce usage of Finalizable in vmTestbase tests.
> 
> Note: The 'verboseOnErrorEnabled' is just not used.
> 
> See isVerboseOnErrorEnabled.
> 
>     public boolean isVerboseOnErrorEnabled() {
>         return errorsSummaryEnabled;
>     }
> 
> 
> Tested with by running tests with different combinations (tier4-7) and tier1.

This pull request has now been integrated.

Changeset: 61aff6db
Author:    Leonid Mesnik <lmesnik at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/61aff6db15d5bdda77427af5ce34d0fe43373197
Stats:     168 lines in 30 files changed: 2 ins; 134 del; 32 mod

8332112: Update nsk.share.Log to don't print summary during VM shutdown hook

Reviewed-by: dholmes, cjplummer

-------------

PR: https://git.openjdk.org/jdk/pull/19209


More information about the serviceability-dev mailing list