RFR: 8328083: degrade virtual thread support for GetObjectMonitorUsage [v4]

Chris Plummer cjplummer at openjdk.org
Wed May 15 19:47:04 UTC 2024


On Wed, 1 May 2024 20:49:02 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review: 1. clarifications in JDWP and JDI spec; 2. clarifications in test comments.
>
> src/jdk.jdi/share/classes/com/sun/jdi/ObjectReference.java line 369:
> 
>> 367: 
>> 368:     /**
>> 369:      * Returns an {@link ThreadReference} for the platform thread, if any,
> 
> Pre-existing issue: It should be "a" not "an", but then in the `@return` section we are using "the", so maybe we should use similar wording here: `...the {@link ThreadReference} of the platform thread...`

The above comment has not been addressed yet. Should be "a ThreadReference" or "the ThreadReference"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19030#discussion_r1602163046


More information about the serviceability-dev mailing list