RFR: 8328083: degrade virtual thread support for GetObjectMonitorUsage [v4]

Serguei Spitsyn sspitsyn at openjdk.org
Wed May 15 20:12:03 UTC 2024


On Wed, 15 May 2024 19:51:51 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review: 1. clarifications in JDWP and JDI spec; 2. clarifications in test comments.
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 1535:
> 
>> 1533:       bool is_virtual = java_lang_VirtualThread::is_instance(thread_oop);
>> 1534:       if (is_virtual) {
>> 1535:         skipped++;
> 
> Do we really need to maintain `skipped`. Isn't not adding to `nWait` the same as skipping?

Good suggestion, thanks. Fixed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19030#discussion_r1602188546


More information about the serviceability-dev mailing list