RFR: 8326716: JVMTI spec: clarify what nullptr means for C/C++ developers [v2]

David Holmes dholmes at openjdk.org
Fri May 17 02:03:02 UTC 2024


On Fri, 17 May 2024 00:43:18 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> The following RFE was fixed recently:
>> [8324680](https://bugs.openjdk.org/browse/JDK-8324680): Replace NULL with nullptr in JVMTI generated code
>> 
>> It replaced all the `NULL`'s in the generated spec with`nullptr`. JVMTI agents can be developed in C or C++.
>> This update is to make it clear that `nullptr` is C programming language `null` pointer.
>> 
>> I think we do not need a CSR for this fix.
>> 
>> Testing: N/A (not needed)
>
> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review: corrected the nullptr clarification

But this clarification doesn't actually clarify that the rest of the spec uses `nullptr`. Based on the proposed wording I would expect things like:

The function may return <code>nullptr</code>

to say

The function may return a null pointer

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19257#pullrequestreview-2062190669


More information about the serviceability-dev mailing list