RFR: 8331557: Serial: Refactor SerialHeap::do_collection [v6]

Albert Mingkun Yang ayang at openjdk.org
Fri May 17 07:44:29 UTC 2024


On Fri, 17 May 2024 07:22:36 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> How about calling them `try_x` and `x` for the public and private API, respectively, e.g. `try_do_full_collection` and `do_full_collection`?
>
> I prefer that to the "no_gc_locker" emphasizing names

I can do that for `try_collect_at_safepoint`, but `SerialHeap::do_full_collection` is an API from `CollectedHeap`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19056#discussion_r1604485388


More information about the serviceability-dev mailing list