RFR: 8328866: Add raw monitor rank support to the debug agent. [v6]

Chris Plummer cjplummer at openjdk.org
Fri May 17 23:01:03 UTC 2024


On Fri, 17 May 2024 20:03:11 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Flip rank order. Some cleanup and better comments for verifyMonitorRank().
>
> src/jdk.jdwp.agent/share/native/libjdwp/util.c line 1145:
> 
>> 1143:  */
>> 1144: 
>> 1145: static jrawMonitorID dbgRawMonitor;
> 
> As the monitor is used to synchronize access to dbg_monitors array, maybe rename it to something like dbg_monitors_lock?

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19044#discussion_r1605602835


More information about the serviceability-dev mailing list