RFR: 8330694: Rename 'HeapRegion' to 'G1HeapRegion' [v12]

Lei Zaakjyu duke at openjdk.org
Fri May 24 12:56:10 UTC 2024


On Tue, 21 May 2024 06:08:54 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Lei Zaakjyu has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   restore
>
> test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SharedStringsHumongous.java line 90:
> 
>> 88:         // before dumping the string table. That means the heap should contain no
>> 89:         // humongous regions.
>> 90:         dumpOutput.shouldNotMatch("gc,region,cds. G1HeapRegion 0x[0-9a-f]* HUM");
> 
> Just a minor nit. I noticed a pre-existing typo on line 87 above. It says "kelp" instead of "kept". Can you fix it?

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18871#discussion_r1613437928


More information about the serviceability-dev mailing list