RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation [v3]

Chris Plummer cjplummer at openjdk.org
Fri May 24 15:53:07 UTC 2024


On Fri, 17 May 2024 10:35:39 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Kevin Walls has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - add an 'also'
>>  - typo
>
> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnection.java line 961:
> 
>> 959:      * @param delegationSubjects should be {@code null}, but a non-null
>> 960:      * array is also accepted for compatibility reasons, which must not
>> 961:      * contain any non-null entries.
> 
> The wording is bit unusual for a parameter description. Just wondering if might be clearer to say "null or an array of null elements" and put add an `@apiNote` to explain that it allows an array with null elements for compatibility reasons. What you have is okay too course, I'm just trying to think of another way to present this odd case.

How about "must be null or an array of all null entries". You could still have an `@apiNote` explaining why.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19253#discussion_r1613693492


More information about the serviceability-dev mailing list