RFR: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation [v3]
Kevin Walls
kevinw at openjdk.org
Fri May 24 17:08:01 UTC 2024
On Fri, 24 May 2024 16:49:25 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> Thanks, appreciate the effort trying to make it perfect.
>> Can't quite say "must be null or an array of all null entries" ..because I suppose it could be an empty array.
>>
>> In reality, the only caller is our code that wraps a null Subject value, in an array, so it's generally a single null in an array.
>>
>> I hope we are OK sticking with "which must not contain any non-null entries" as that does cover it (and implicitly does tell you an empty array is fine).
>
> For me the main hold up is using "should". Maybe:
>
> "Must be null or an array that doesn't contain any non-null entries."
OK I think I can get rid of "should"....
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19253#discussion_r1613782613
More information about the serviceability-dev
mailing list