RFR: 8332070: Convert package.html files in `java.management` to package-info.java [v2]
Nizar Benalla
nbenalla at openjdk.org
Mon May 27 09:01:48 UTC 2024
> This is a simple noreg cleanup. The motivation was that I noticed javac doesn't recognise package.html files well.
>
> Some of the contents of the `package.html` files (and code in the package) may be outdated, but I think it is out of scope for this PR.
>
> I have also changed three `{@link }` usages with the `href` that would have been in the generated HTML.
> Because referencing an element from an other module wouldn't work even when using the `module/package.class#member`, if the `module-info.java` file does not have "require `<name>`".
>
> I am referring to line 69 in
> `src/java.management/share/classes/javax/management/monitor/package-info.java`
> and lines 90 and 120 in
> `src/java.management/share/classes/javax/management/remote/package-info.java`
>
> Adding 2 dependencies just for 3 links didn't seem right.
>
> edit: passes all tests, the failing test is a github actions issue
Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
better indentation - no content changes
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/19399/files
- new: https://git.openjdk.org/jdk/pull/19399/files/3bfc760d..c5d3147a
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=19399&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=19399&range=00-01
Stats: 1141 lines in 8 files changed: 332 ins; 334 del; 475 mod
Patch: https://git.openjdk.org/jdk/pull/19399.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/19399/head:pull/19399
PR: https://git.openjdk.org/jdk/pull/19399
More information about the serviceability-dev
mailing list