RFR: 8332919: SA PointerLocation needs to print a newline after dumping java thread info for JNI Local Ref

Kevin Walls kevinw at openjdk.org
Tue May 28 09:49:06 UTC 2024


On Fri, 24 May 2024 20:03:53 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> If PointerLocation discovers that an address is for a JNI local ref, it will print information about the thread that owns the JNI local ref. For JavaThreads it calls the printThreadIDOn(tty) method. There's a comment on the call that says that it 'includes "\n"'. This is actually not true, and a separate println() is needed. I noticed this when using the clhsdb findpc command on a JNI local ref and noted that the next "hdsb> " prompt was printed at the end of the findpc output instead of on a new line.

Marked as reviewed by kevinw (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/19402#pullrequestreview-2082284417


More information about the serviceability-dev mailing list