RFR: 8328611: Thread safety issue in com.sun.tools.jdi.ReferenceTypeImpl::classObject
Alex Menkov
amenkov at openjdk.org
Wed May 29 01:13:02 UTC 2024
On Tue, 28 May 2024 23:20:48 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
> Fixed "double-checked-locking" bug in `ReferenceImplType.classObject()`. Details in the first comment. Tested with the following:
> - com/sun/jdi
> - nsk/jdi
> - nsk/jdwp
> - nsk/jdb
Marked as reviewed by amenkov (Reviewer).
src/jdk.jdi/share/classes/com/sun/tools/jdi/ReferenceTypeImpl.java line 185:
> 183: public String signature() {
> 184: if (signature == null) {
> 185: // Does not need synchronization. Worst case is static info is fetched twice
Could you add dot at the end of all updated comments
-------------
PR Review: https://git.openjdk.org/jdk/pull/19439#pullrequestreview-2084073364
PR Review Comment: https://git.openjdk.org/jdk/pull/19439#discussion_r1618047117
More information about the serviceability-dev
mailing list