Integrated: 8333013: Update vmTestbase/nsk/share/LocalProcess.java to don't use finalization
Leonid Mesnik
lmesnik at openjdk.org
Wed May 29 15:04:11 UTC 2024
On Tue, 28 May 2024 03:15:43 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
> The vmTestbase/nsk/share/LocalProcess.java is a wrapper for debuggee process. It extends FinalizableObject to kill the debuggee process.
>
> The debuggee process is used by nsk.jdb tests only, see runTest(...) in vmTestbase/nsk/share/jdb/JdbTest.java:
> https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/vmTestbase/nsk/share/jdb/JdbTest.java#L189
>
> I verified that process is always already terminated when is cleaned during VM shutdown hook,
> So the fix is just to remove the finalization.
>
> I also moved LocalProcess into nsk.share.jdb to reduce the visibility of class and hardened checks in runTest.
This pull request has now been integrated.
Changeset: bc7d9e3d
Author: Leonid Mesnik <lmesnik at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/bc7d9e3d0bc663bbbeb068889082da4a9f0fa8de
Stats: 343 lines in 3 files changed: 156 ins; 179 del; 8 mod
8333013: Update vmTestbase/nsk/share/LocalProcess.java to don't use finalization
Reviewed-by: cjplummer, amenkov
-------------
PR: https://git.openjdk.org/jdk/pull/19418
More information about the serviceability-dev
mailing list