RFR: 8332785: Replace naked uses of UseSharedSpaces with CDSConfig::is_using_archive

[Thomas Stuefe]

On Wed, 29 May 2024 18:12:25 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

> Hi folks, 
> 
> This PR addresses [8332785](https://bugs.openjdk.org/browse/JDK-8332785) replacing all naked uses for ```UseSharedSpaces``` with ```CDSConfig::is_using_archive```. 
> 
> Testing: 
> - [x] Tier 1 with GHA. 
> 
> Thanks, 
> Sonia

Looks good, minus the nit @dholmes-ora mentioned. Please make sure Copyrights are updated.

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19463#pullrequestreview-2089995893