RFR: 8311177: Switching to interpreter only mode in carrier thread can lead to crashes [v2]

Serguei Spitsyn sspitsyn at openjdk.org
Fri May 31 23:58:07 UTC 2024


On Thu, 30 May 2024 18:59:10 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review: addressed nits in new test
>
> src/hotspot/share/prims/jvmtiThreadState.cpp line 674:
> 
>> 672:   }
>> 673:   // enable interp_only_mode for carrier thread if it has pending bit
>> 674:   process_pending_interp_only(thread);
> 
> So for the last unmount case we will call this before doing the JVMTI state rebinding, but shouldn't it be called after it in VTMS_vthread_end? Actually why not moving this call inside rebind_to_jvmti_thread_state_of()?

Thank you for the comment!
I was also thinking about placing it to the `rebind_to_jvmti_thread_state_of()`. 
I've made  and pushed this change now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19438#discussion_r1623046562


More information about the serviceability-dev mailing list