RFR: 8304824: NMT should not use ThreadCritical [v9]

[Markus Grönlund]

On Mon, 28 Oct 2024 16:12:39 GMT, Robert Toyonaga <duke at openjdk.org> wrote:

>> ### Summary
>> This PR just replaces `ThreadCritical` with a lock specific to NMT.  `ThreadCritical` is a big lock and is unnecessary for the purposes of NMT. I've implemented the new lock with a semaphore so that it can be used early before VM init.  There is also the possibility of adding assertions in places we expect NMT to have synchronization. I haven't added assertions yet in many places because some code paths such as the (NMT tests)  don't lock yet. I think it makes sense to close any gaps in locking in another PR in which I can also add more assertions. 
>> 
>> Testing:
>> - hotspot_nmt
>> - gtest:VirtualSpace
>> - tier1
>
> Robert Toyonaga has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - add a comment explaining lock rank
>  - remove unnecessary dropping of tracking level

src/hotspot/share/runtime/mutexLocker.hpp line 31:

> 29: #include "runtime/flags/flagSetting.hpp"
> 30: #include "runtime/mutex.hpp"
> 31: #include "runtime/thread.hpp"

This include is not needed because there are no uses that require the definition of Thread.

After pull, I am getting circularity errors from runtime/thread.hpp -> jfr/support/jfrThreadLocal.hpp (which now needs runtime/mutexLocker.hpp (-> runtime/thread.hpp)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20852#discussion_r1826330949