RFR: 8343838: Test EmptyDomainNotificationTest.java fails with ListenerNotFoundException [v2]

[David Holmes]

On Mon, 11 Nov 2024 09:18:34 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Looks like EmptyDomainNotificationTest has been working by accident for nearly 20 years.
>> Removing notifications when not specifying a domain part of the ObjectName has actually been failing, but calling removeNotificationListener() without a domain has not been sharing the Exception.
>> 
>> ServerNotifForwarder.removeNotificationListener DOES need to add a domain part to an ObjectName that does not have one.
>> 
>> ServerNotifForwarder.addNotificationListener was changed in JDK-6238731, which is what this test is testing.
>> 
>> There is a numeric ID, BUT it still calls removeNotificationListener(ObjectName name, Integer listenerID) it does matter that the ObjectName does not match.
>> 
>> Maybe the failure to record and throw the Exceptions was the reason it was thought the numeric ID made the domain unnecessary.
>
> Kevin Walls has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Update problemlist
>  - Merge remote-tracking branch 'upstream/master' into 8343838_Notification
>  - 8343838: Test EmptyDomainNotificationTest.java fails with ListenerNotFoundException

Marked as reviewed by dholmes (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21993#pullrequestreview-2427162816