Integrated: 8343838: Test EmptyDomainNotificationTest.java fails with ListenerNotFoundException

[Kevin Walls]

On Fri, 8 Nov 2024 20:46:52 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> Looks like EmptyDomainNotificationTest has been working by accident for nearly 20 years.
> Removing notifications when not specifying a domain part of the ObjectName has actually been failing, but calling removeNotificationListener() without a domain has not been sharing the Exception.
> 
> ServerNotifForwarder.removeNotificationListener DOES need to add a domain part to an ObjectName that does not have one.
> 
> ServerNotifForwarder.addNotificationListener was changed in JDK-6238731, which is what this test is testing.
> 
> There is a numeric ID, BUT it still calls removeNotificationListener(ObjectName name, Integer listenerID) it does matter that the ObjectName does not match.
> 
> Maybe the failure to record and throw the Exceptions was the reason it was thought the numeric ID made the domain unnecessary.

This pull request has now been integrated.

Changeset: 50161322
Author:    Kevin Walls <kevinw at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/5016132291b8cb94c37ffb9397282927df87a3c5
Stats:     15 lines in 2 files changed: 12 ins; 2 del; 1 mod

8343838: Test EmptyDomainNotificationTest.java fails with ListenerNotFoundException

Reviewed-by: dholmes

-------------

PR: https://git.openjdk.org/jdk/pull/21993