RFR: 8343781: Add since checker test to the Serviceability area modules [v2]
Nizar Benalla
nbenalla at openjdk.org
Thu Nov 14 00:53:08 UTC 2024
On Tue, 12 Nov 2024 19:21:08 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> Nizar Benalla has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - fix mistake in module name passed to jdk.jconsole test
>> - Add backticks to mentions of `@since`, to avoid jtreg mistaking it with a jtreg tag
>>
>> Revert "remove backticks"
>>
>> This reverts commit 0abe3080391e83cae62253f56c28d98efa0ed253.
>
> test/jdk/tools/sincechecker/modules/jdk.jconsole/JdkJconsoleCheckSince.java line 29:
>
>> 27: * @summary Test for @since in jdk.jconsole module
>> 28: * @library /test/lib /test/jdk/tools/sincechecker
>> 29: * @run main SinceChecker jdk.jartool
>
> Q: Should it be `jdk.console` instead of `jdk.jartool`?
It should indeed be `jdk.console`. Fixed in [4aa468f](https://github.com/openjdk/jdk/pull/21983/commits/4aa468f0b6117879687343ecff84daf32e3a9acb), Thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21983#discussion_r1841373957
More information about the serviceability-dev
mailing list