RFR: 8343781: Add since checker test to the Serviceability area modules [v2]
Serguei Spitsyn
sspitsyn at openjdk.org
Thu Nov 14 01:01:38 UTC 2024
On Thu, 14 Nov 2024 00:53:08 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
>> Can I please get a review for this PR that add tests to verify the value of `@since` tags to the Serviceability area modules. The test is described in this [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html). This issue is similar to JDK-8341399, JDK-8331051 and JDK-8343442.
>>
>> The benefit from this is helping API authors and reviewer validate the accuracy of `@since` in their source code (and subsequently, in the generated documentation). And lessen the burden on Reviewers.
>>
>> The test has been added for `java.base` and a few other modules and has helped catch some bugs before they make it to the JDK.
>>
>> TIA
>
> Nizar Benalla has updated the pull request incrementally with two additional commits since the last revision:
>
> - fix mistake in module name passed to jdk.jconsole test
> - Add backticks to mentions of `@since`, to avoid jtreg mistaking it with a jtreg tag
>
> Revert "remove backticks"
>
> This reverts commit 0abe3080391e83cae62253f56c28d98efa0ed253.
Thank you for the update. Looks good.
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21983#pullrequestreview-2434766357
More information about the serviceability-dev
mailing list