RFR: 8337511: Implement JEP 404: Generational Shenandoah (Experimental) [v6]
Aleksey Shipilev
shade at openjdk.org
Thu Nov 14 10:43:15 UTC 2024
On Wed, 13 Nov 2024 23:07:02 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> test/hotspot/jtreg/gc/shenandoah/oom/TestThreadFailure.java line 61:
>>
>>> 59: // case that the previously instantiated NastyThread accumulated more than SheanndoahNoProgressThreshold
>>> 60: // unproductive GC cycles before failing, the main thread may not try a Full GC before it experiences
>>> 61: // OutOfMemoryError exception.
>>
>> Do you really need comments in this test?
>
> This test was a sore spot for us and we spent quite some time to make it pass. I don't think the code is very clear on its face about what the test expects, so I'd prefer to keep this comment.
OK, fine!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21273#discussion_r1841996383
More information about the serviceability-dev
mailing list