RFR: 8341916: Remove ProtectionDomain related hotspot code and tests [v5]

[David Holmes]

On Thu, 14 Nov 2024 16:02:56 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Remove Hotspot code that passes protection_domain around class loading so that checkPackageAccess can be called and the result stored.  With the removal of the Security Manager in JEP 486, this code no longer does anything.
>> 
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Purge last references to SecurityManager.

src/hotspot/share/classfile/javaClasses.cpp line 1617:

> 1615:   macro(_holder_offset,        k, "holder", thread_fieldholder_signature, false); \
> 1616:   macro(_name_offset,          k, vmSymbols::name_name(), string_signature, false); \
> 1617:   macro(_contextClassLoader_offset, k, "contextClassLoader", classloader_signature, false); \

I didn't think the context class loader was related to SM in any way. ??

src/hotspot/share/logging/logDiagnosticCommand.hpp line 62:

> 60:   }
> 61: 
> 62:   static const JavaPermission permission() {

Is any of this permission stuff still relevant? I couldn't figure out what ultimately looks at them. ??

src/hotspot/share/prims/jvm.cpp line 154:

> 152: */
> 153: 
> 154: extern void trace_class_resolution(Klass* to_class) {

why `extern` ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22064#discussion_r1843117025
PR Review Comment: https://git.openjdk.org/jdk/pull/22064#discussion_r1843121894
PR Review Comment: https://git.openjdk.org/jdk/pull/22064#discussion_r1843122642