RFR: 8341916: Remove ProtectionDomain related hotspot code and tests [v6]

Coleen Phillimore coleenp at openjdk.org
Sat Nov 16 14:25:33 UTC 2024


On Sat, 16 Nov 2024 03:22:01 GMT, John R Rose <jrose at openjdk.org> wrote:

>> src/hotspot/share/prims/jvm.cpp line 169:
>> 
>>> 167:     while (!vfst.at_end()) {
>>> 168:       Method* m = vfst.method();
>>> 169:       if (!vfst.method()->method_holder()->is_subclass_of(vmClasses::ClassLoader_klass())) {
>> 
>> We are no longer skipping AC frames, but user code will continue to use AC calls, even if they are silly.  Will this affect any existing caller-sensitive calculations?  The failure mode would be that a "get-caller-class" query would return AC.class, not the caller of the AC method.
>
> (Wait, I think my comment is in the wrong place.  This is just tracing code, but I thought I saw a similar change for the general walker code…)
> 
> Right, cancel the previous comment.

Yes, we still have the security stack walk without this using the caller sensitive mechanism.  This was only for logging.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22064#discussion_r1844986976


More information about the serviceability-dev mailing list