RFR: 8344181: Remove SecurityManager and related calls from jdk.management and jdk.management.agent [v2]

Kevin Walls kevinw at openjdk.org
Tue Nov 19 14:24:16 UTC 2024


On Mon, 18 Nov 2024 19:25:36 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Kevin Walls has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - space
>>  - Missed getBoolean
>
> src/jdk.management/share/classes/com/sun/management/internal/GcInfoCompositeData.java line 77:
> 
>> 75:             Field f = cl.getDeclaredField("builder");
>> 76:             f.setAccessible(true);
>> 77:             builder =  (GcInfoBuilder)f.get(info);
> 
> Suggestion:
> 
>             builder = (GcInfoBuilder)f.get(info);

done

> src/jdk.management/share/classes/com/sun/management/internal/HotSpotDiagnostic.java line 52:
> 
>> 50: 
>> 51:         String propertyName = "jdk.management.heapdump.allowAnyFileSuffix";
>> 52:         boolean allowAnyFileSuffix = Boolean.parseBoolean(System.getProperty(propertyName, "false"));
> 
> can be simplified to `Boolean.getBoolean(propertyName)`

Yes, missed that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22155#discussion_r1848455057
PR Review Comment: https://git.openjdk.org/jdk/pull/22155#discussion_r1848454800


More information about the serviceability-dev mailing list