RFR: 8337511: Implement JEP 404: Generational Shenandoah (Experimental) [v7]

William Kemper wkemper at openjdk.org
Tue Nov 19 23:02:22 UTC 2024


On Mon, 18 Nov 2024 16:22:31 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> William Kemper has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 510 commits:
>> 
>>  - Merge branch 'merge-latest' into great-genshen-pr-redux
>>  - Use new CompactHeader forwarding APIs in generational mode
>>  - Merge remote-tracking branch 'jdk/master' into merge-latest
>>  - Merge
>>  - 8343649: Shenandoah: ShenandoahEvacInfo event does not follow JFR guidelines
>>    
>>    Reviewed-by: wkemper
>>  - Merge
>>  - 8343227: GenShen: Fold resource mark into management of preselected regions
>>    
>>    Reviewed-by: kdnilsen
>>  - Merge openjdk/jdk tip into great-genshen-pr-redux
>>  - Merge remote-tracking branch 'jdk/master' into merge-latest
>>  - Merge remote-tracking branch 'jdk/master' into merge-latest
>>  - ... and 500 more: https://git.openjdk.org/jdk/compare/889f9062...5e02b5d8
>
> src/hotspot/share/gc/shenandoah/shenandoahPhaseTimings.cpp line 193:
> 
>> 191:     Phase phase = Phase(pi);
>> 192:     if (is_worker_phase(phase)) {
>> 193:       double sum = uninitialized();
> 
> I think you can avoid changing this method to limit the churn.

Hmm, I find the version in the PR much more readable. How about we upstream these changes separately?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21273#discussion_r1849160336


More information about the serviceability-dev mailing list