RFR: 8340334: Update jcmd VM.events max parameter to be INT

Chris Plummer cjplummer at openjdk.org
Wed Nov 20 05:13:19 UTC 2024


On Tue, 19 Nov 2024 00:40:09 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> The  jcmd VM.events max parameter type is changed to INT.
> Also,I noted the max <= 0 is ignored, so I updated documentation and set "0" as a default value.
> The jcmd exists if parameter is negative now.
> 
> The `max` is `int` while really it is the unsigned int. However I don't think it makes sense to change it to `size_t` or `unsigned int` in all places where 'max' is used.

Looks good, but I agree that the docs should be updated with this PR - src/jdk.jcmd/share/man/jcmd.md

-------------

PR Review: https://git.openjdk.org/jdk/pull/22224#pullrequestreview-2447416788


More information about the serviceability-dev mailing list