RFR: 8340334: Update jcmd VM.events max parameter to be INT [v2]

[David Holmes]

On Tue, 19 Nov 2024 10:12:15 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> src/hotspot/share/services/diagnosticCommand.hpp line 892:
>> 
>>> 890: protected:
>>> 891:   DCmdArgument<char*> _log;
>>> 892:   DCmdArgument<jlong> _max;
>> 
>> Why `jlong` and not `jint`?
>
> Everything which parses an integer option uses 
> 
> DCmdArgument<jlong>
> 
>  (e.g. heap dump parallelism, etc...)
> 
> 
> DCmdArgument<jlong>::parse_value(..)
> 
> does the parsing, we have never had a definition for
> 
> DCmdArgument<jint>

Okay but just to be clear, this change means that the maximum value of this parameter is no longer limited to a 32-bit integer maximum, but is now a 64-bit maximum - the old `parse_integer` function was passed `int` not `jlong`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22224#discussion_r1851374996