RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v3]

Sergey Chernyshev schernyshev at openjdk.org
Sat Nov 23 00:09:15 UTC 2024


On Fri, 22 Nov 2024 16:48:04 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> The added code in `CgroupUtil::adjust_controller` runs for cg v1 and cg v2 when path adjustment is deemed needed. So I'm not clear why it's needed for cg v2

It looks like there's no way to see at this point, if we are in cgroup v1 or v2 - if I am not mistaken.

> I thought we have established that for cg v2 && `--cgroupns=host` the current path adjustment is sufficient? What am I missing?

The current path adjustment still needs correction of `lowest_limit` in cg v2. Also allocating `limit_cg_path` is important, that's why I added the if block.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21808#discussion_r1854921422


More information about the serviceability-dev mailing list