RFR: 8337199: Add jcmd Thread.vthread_scheduler and Thread.vthread_pollers diagnostic commands [v2]

[Kevin Walls]

On Thu, 28 Nov 2024 15:52:01 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> test/hotspot/jtreg/serviceability/dcmd/thread/VThreadCommandsTest.java line 96:
>> 
>>> 94:                 .shouldContain("Read I/O pollers:")
>>> 95:                 .shouldContain("Write I/O pollers:")
>>> 96:                 .shouldMatch("^\\[0\\] sun.nio.ch..+ \\[registered = [\\d]+, owner = .+\\]$");
>> 
>> Just a nit but are there three dots here in sun.nio.ch. that should literally match, so need the \\ 
>> and then the other two other dots with a plus sign, to match one or more characters.
>
> Well spotted, these should be escaped although it not doing so won't impact the match here.

Yes -it was almost the definitive bikeshedding comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22414#discussion_r1862430118