RFR: 8341246: Test com/sun/tools/attach/PermissionTest.java fails access denied after JDK-8327114 [v2]

SendaoYan syan at openjdk.org
Wed Oct 2 15:44:58 UTC 2024


On Tue, 1 Oct 2024 21:13:35 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   merge two comments enclosed with /* ... */ on two lines
>
> test/jdk/com/sun/tools/attach/java.policy.allow line 17:
> 
>> 15: 
>> 16:     /* to read configuration file in META-INF/services, write/delete .attach_pid<pid>, 
>> 17:     and read symbolic link of /proc/self/ns/mnt */
> 
> Suggestion:
> 
>     /* 
>      * To read configuration file in META-INF/services, write/delete .attach_pid<pid>, 
>      * and read symbolic link of /proc/self/ns/mnt.
>      */

Thanks for the review. The comment has been changed according your advice.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21269#discussion_r1784795554


More information about the serviceability-dev mailing list