RFR: 8339979: VirtualThreadSchedulerMXBeanTest.testReduceParallelism fails intermittently [v2]
Kevin Walls
kevinw at openjdk.org
Thu Oct 3 09:39:36 UTC 2024
On Thu, 3 Oct 2024 09:03:06 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> This is a test only change. VirtualThreadSchedulerMXBeanTest.testReduceParallelism can fail when getMountedVirtualThreadCount over estimates the number of mounted virtual threads.
>>
>> The test is changed from using getMountedVirtualThreadCount to sample the result until it reads the expected value.
>>
>> As part of the change, the awaitXXX supporting methods are refactored to take a predicate and the trace message.
>
> Alan Bateman has updated the pull request incrementally with one additional commit since the last revision:
>
> Bring back Gte/Lte methods, reduces changes to one test
Hi, looks really good.
-------------
Marked as reviewed by kevinw (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21310#pullrequestreview-2345117198
More information about the serviceability-dev
mailing list