RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang

[Matthias Baesken]

On Tue, 8 Oct 2024 16:30:36 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> There are a few warnings as errors occurring when building on Linux with clang (clang15). Mostly these are some kind of 'unused' warnings.
>> Might be related to https://bugs.openjdk.org/browse/JDK-8339156 .
>
> src/jdk.hotspot.agent/linux/native/libsaproc/symtab.c line 393:
> 
>> 391: 
>> 392:       hcreate_r(htab_sz, symtab->hash_table);
>> 393:       // guarantee(rslt, "unexpected failure: hcreate_r");
> 
> The commented out guarantee line references rslt. I'm not so sure why it was commented out, but it goes back to the initial load of the file 17 years ago. It looks like the correct thing to do if rslt is null is to "goto bad;" but that change is probably beyond the scope of this PR. Maybe file a new CR.

Hi Chris , I created https://bugs.openjdk.org/browse/JDK-8341820 for the return value checking.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21407#discussion_r1792911176