RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang [v2]
    Chris Plummer 
    cjplummer at openjdk.org
       
    Wed Oct  9 15:38:03 UTC 2024
    
    
  
On Wed, 9 Oct 2024 10:36:28 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> Might be a good idea to have rslt commented out rather than removed outright if we don't want to forget about it. guarantee on a variable that doesn't exist will be rather confusing to anyone reading through the code
>
>> Might be a good idea to have rslt commented out 
> 
> Why not; Chris what do you say ?
Yeah, I think it is good like this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21407#discussion_r1793746144
    
    
More information about the serviceability-dev
mailing list