Integrated: 8341794: Fix ExceptionOccurred in jdk.attach
Justin Lu
jlu at openjdk.org
Fri Oct 11 21:33:31 UTC 2024
On Thu, 10 Oct 2024 21:55:37 GMT, Justin Lu <jlu at openjdk.org> wrote:
> Please review this PR which is part of the bigger umbrella bug: https://bugs.openjdk.org/browse/JDK-8341542.
>
> This fixes incorrect usage of `jthrowable ExceptionOccurred(JNIEnv *env)` within _jdk.attach_.
> This corrects instances where the return value is being treated as a boolean. Such occurrences are replaced with `jboolean ExceptionCheck(JNIEnv *env)`.
>
> JNI Docs - ExceptionCheck
>> We introduce a convenience function to check for pending exceptions without creating a local reference to the exception object. ... Returns JNI_TRUE when there is a pending exception; otherwise, returns JNI_FALSE.
This pull request has now been integrated.
Changeset: c4965d9b
Author: Justin Lu <jlu at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/c4965d9b135b58e0b3604bc1cc60978ad4c8c11b
Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
8341794: Fix ExceptionOccurred in jdk.attach
Reviewed-by: amenkov, cjplummer
-------------
PR: https://git.openjdk.org/jdk/pull/21459
More information about the serviceability-dev
mailing list