RFR: 8339289: Parameter size mismatch between client and VM sides of the Attach API - Windows [v2]

[Alex Menkov]

On Sat, 12 Oct 2024 11:04:25 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   feedback
>
> src/hotspot/share/services/attachListener.cpp line 649:
> 
>> 647: 
>> 648:   return true;
>> 649: }
> 
> Nit: This function is too big. I'd suggest to split it to make more readable. For example, the lines 596-648 can be moved to new function which is called by the `AttachOperation::read_request()'.

Done

> src/jdk.attach/windows/classes/sun/tools/attach/VirtualMachineImpl.java line 46:
> 
>> 44: 
>> 45:     private volatile long hProcess;     // handle to the process
>> 46:     private int ver = VERSION_1;        // updated by detectVersion on attach
> 
> Nit: The comment is not fully accurate as the result returned by the `detectVersion()` is stored in this private field by the `VirtualMachineImpl` constructor.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20782#discussion_r1800056341
PR Review Comment: https://git.openjdk.org/jdk/pull/20782#discussion_r1800056007