RFR: 8338603: DiagnosticCommandMBean operations should standardize types for parameters [v2]

Kevin Walls kevinw at openjdk.org
Tue Oct 15 08:21:18 UTC 2024


On Thu, 10 Oct 2024 08:51:38 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> DiagnosticCommandImpl should only publish parameter types in a known standard set, and use "STRING" on anything else.
>> e.g. We can say "FILE" in the help output for jcmd, as that's for humans, but the MBean parameter info should contain "STRING".
>
> Kevin Walls has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into 8338603_dcmd_mbean_types
>  - Update comment about type name knowledge
>  - Test update
>  - 8338603: DiagnosticCommandMBean operations should standardize types for parameters.

Thanks Chris.

Hoping to get a second approval.
Would be great to get this change done, then I can go back and know that the man page change in https://github.com/openjdk/jdk/pull/20401
will be correct.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21040#issuecomment-2413205144


More information about the serviceability-dev mailing list