RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

[William Kemper]

On Fri, 11 Oct 2024 22:12:25 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahCardStats.hpp line 40:
>> 
>>> 38:   DIRTY_SCAN_OBJS     = 6,
>>> 39:   ALTERNATIONS        = 7,
>>> 40:   MAX_CARD_STAT_TYPE  = 8
>> 
>> Are the numerical values relevant or what is the reason to spell them out?
>
> Not needed; explicit enumeration values can be removed.

https://github.com/openjdk/shenandoah/pull/514

>> src/hotspot/share/gc/shenandoah/shenandoahCardStats.hpp line 46:
>> 
>>> 44:   CARD_STAT_SCAN_RS       = 0,
>>> 45:   CARD_STAT_UPDATE_REFS   = 1,
>>> 46:   MAX_CARD_STAT_LOG_TYPE  = 2
>> 
>> Same here?
>
> Yes, same; explicit enumeration values can be removed.

https://github.com/openjdk/shenandoah/pull/514

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21273#discussion_r1801975222
PR Review Comment: https://git.openjdk.org/jdk/pull/21273#discussion_r1801975588