RFR: 8339871: serviceability/sa/TestDebugInfoDecode.java should be driver
Leonid Mesnik
lmesnik at openjdk.org
Tue Oct 15 23:01:14 UTC 2024
On Tue, 15 Oct 2024 10:12:21 GMT, Ramkumar Sunderbabu <rsunderbabu at openjdk.org> wrote:
> Passing "-Xmx1g -Xcomp" to the LingeredApp.
> Testing: tier1
The only thing that is missed it change `othervm` to `driver`.
The adding -Xcomp in LingeredApp.startApp(theApp, "-Xmx1g", "-Xcomp");
should works fine except when -Xint/-Xmixed is set explicitly.
So generally test like needs to have
@requires vm.compMode == "null" | vm.compMode == "Xcomp"
However we don't set these modes, so it might be skipped. A lot of our test set Xcomp without any requires now.
Also, the vm.flagless is not required, since test support various vm flags.
Limiting tests to run only -Xcomp is set is also not needed for this test.
The another thing to check (unrelated to the fix) is if test is executed in tier1 and should it be there.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21519#issuecomment-2415309978
More information about the serviceability-dev
mailing list