RFR: 8340698: JVMTI FRAME_POP event is sometimes missed if NotifyFramePop is called as a method is returning [v2]

[Chris Plummer]

On Tue, 15 Oct 2024 23:43:16 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor comment tweak
>
> test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStressTest/NotifyFramePopStressTest.java line 103:
> 
>> 101:                 }
>> 102:             }
>> 103:             if (waitCount > 50) {
> 
> Is 50 is enough here? (like in "Xcomp" mode) the cycle above exits after 1000 iterations.

It was written to fail if the count is over 50, but it will wait up to 1000 before exiting the loop to provide a bit of debugging info. If it gets to a 1000, then the test is probably stuck. If it fail let's say at 75, then maybe the test just needs an adjustment to wait for more iterations.

> test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStressTest/libNotifyFramePopStressTest.cpp line 169:
> 
>> 167:   err= jvmti->NotifyFramePop(thread, 0);
>> 168:   if (err == JVMTI_ERROR_OPAQUE_FRAME || err == JVMTI_ERROR_DUPLICATE) {
>> 169:     return JNI_FALSE;
> 
> `deallocate(jvmti, jni, name);`

Also add a LOG similar to the one below that is done if successful.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1802168851
PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1802166576