RFR: 8340698: JVMTI FRAME_POP event is sometimes missed if NotifyFramePop is called as a method is returning [v2]

[Serguei Spitsyn]

On Tue, 15 Oct 2024 23:45:15 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor comment tweak
>
> test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStressTest/libNotifyFramePopStressTest.cpp line 43:
> 
>> 41: #endif
>> 42: 
>> 43: #endif
> 
> This is copy of some old .c code. you don't need it in .cpp

Thanks, removed obsolete code.

> test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStressTest/libNotifyFramePopStressTest.cpp line 45:
> 
>> 43: #endif
>> 44: 
>> 45: static jvmtiEnv *jvmti = NULL;
> 
> NULL -> nullptr

Thanks. Fixed all occurrences.

> test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStressTest/libNotifyFramePopStressTest.cpp line 76:
> 
>> 74:   jclass cls = NULL;
>> 75:   char* csig = NULL;
>> 76:   char* name = NULL;
> 
> NULL -> nullptr

Fixed.

> test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStressTest/libNotifyFramePopStressTest.cpp line 83:
> 
>> 81:   check_jvmti_status(jni, err, "FramePop: Failed in JVMTI GetMethodDeclaringClass");
>> 82: 
>> 83:   err =jvmti->GetClassSignature(cls, &csig, NULL);
> 
> NULL -> nullptr

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1802204640
PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1802206054
PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1802206722
PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1802206932