RFR: 8340698: JVMTI FRAME_POP event is sometimes missed if NotifyFramePop is called as a method is returning [v2]

Serguei Spitsyn sspitsyn at openjdk.org
Wed Oct 16 02:13:11 UTC 2024


On Tue, 15 Oct 2024 23:50:42 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor comment tweak
>
> test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStressTest/libNotifyFramePopStressTest.cpp line 49:
> 
>> 47: static jvmtiEventCallbacks callbacks;
>> 48: static volatile jint popCount = 0;
>> 49: static char* lastNotifyMethod;
> 
> it's accessed from different threads. should be volative at least (but better would be be use atomic). The same for `popCount` and `failed`

Thanks. Made volatile:`lastNotifyMethod` and `failed`.
Renamed according to native naming convention:
  `popCount` => `pop_count`, `lastNotifyMethod` => `last_notify_method`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1802235396


More information about the serviceability-dev mailing list