RFR: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows [v20]

[David Holmes]

On Wed, 16 Oct 2024 12:49:34 GMT, Simon Tooke <stooke at openjdk.org> wrote:

>> test/hotspot/gtest/runtime/test_os.cpp line 425:
>> 
>>> 423:   EXPECT_TRUE(returnedBuffer == nullptr);
>>> 424: #if defined(_WINDOWS)
>>> 425:   EXPECT_TRUE(errno == ENAMETOOLONG);
>> 
>> Why is this the case? Our implementation does not set it and `_fullpath` makes no mention of it.
>
> This is Windows behaviour - Windows 10 with VS 2022 at least.  The existence of a file is not checked, but that non-existent filename better fit into the given buffer!

Okay. This behaviour is not specified but the test passed on our CI on Windows Server 2016 and 2019.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20683#discussion_r1803965341