RFR: 8340698: JVMTI FRAME_POP event is sometimes missed if NotifyFramePop is called as a method is returning [v4]

Serguei Spitsyn sspitsyn at openjdk.org
Thu Oct 17 15:44:21 UTC 2024


On Wed, 16 Oct 2024 18:25:46 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review: resolved comments from Alex and Chris
>
> test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStressTest/libNotifyFramePopStressTest.cpp line 160:
> 
>> 158:   err= jvmti->NotifyFramePop(thread, 0);
>> 159:   if (err == JVMTI_ERROR_OPAQUE_FRAME || err == JVMTI_ERROR_DUPLICATE) {
>> 160:     LOG("\nNotifyFramePop for method %d returned acceptable error: %s\n", name, TranslateError(err));
> 
> format for 1st arg (name) should be `%s`
> Suggestion:
> 
>     LOG("\nNotifyFramePop for method %s returned acceptable error: %s\n", name, TranslateError(err));

Thanks. I've also discovered and fixed it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1805014234


More information about the serviceability-dev mailing list