RFR: 8341273: JVMTI is not properly hiding some continuation related methods [v3]

[Serguei Spitsyn]

On Tue, 15 Oct 2024 21:26:26 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Disallow NotifyFramePop for enter/enter0/VirtualThread.run/VThreadContinuation.run
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 588:
> 
>> 586:   // There should not be any VTMS transition here. This is for safety.
>> 587:   if (java_thread->is_in_VTMS_transition()) {
>> 588:     jvf = JvmtiEnvBase::check_and_skip_hidden_frames(java_thread, jvf);
> 
> The code now checks `java_thread->is_in_VTMS_transition()`, so it may be simplified to
> Suggestion:
> 
>     jvf = JvmtiEnvBase::check_and_skip_hidden_frames(true, jvf);

Thank you for the comment. Unfortunately, with my latest update it is not relevant anymore.

> src/hotspot/share/prims/jvmtiEnvBase.cpp line 753:
> 
>> 751:     // Skip hidden frames only for carrier threads
>> 752:     // which are in non-temporary VTMS transition.
>> 753:     jvf = check_and_skip_hidden_frames(jt, jvf);
> 
> Can be
> Suggestion:
> 
>     jvf = check_and_skip_hidden_frames(true, jvf);

Thank you for the comment. Unfortunately, with my latest update it is not relevant anymore.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21397#discussion_r1805031938
PR Review Comment: https://git.openjdk.org/jdk/pull/21397#discussion_r1805032070