RFR: 8304824: NMT should not use ThreadCritical [v8]

[Robert Toyonaga]

On Sat, 12 Oct 2024 18:42:34 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> Robert Toyonaga has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update src/hotspot/share/utilities/vmError.cpp
>>   
>>   Co-authored-by: David Holmes <62092539+dholmes-ora at users.noreply.github.com>
>
> Just an important test or comparison is needed here. Do you have any comparison of  the performance before and after this PR change set? Even if no degrading is expected, better to test it.

Hi @afshin-zafari!  I haven't compared the performance yet. I can try to look into this next week. But I don't think there should be any difference because we've only switched out the lock. Maybe there would even be an improvement because the lock is less coarse (but probably not much difference since it's only locking around virtual memory, not mallocs).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20852#issuecomment-2423201201