RFR: 8341927: Remove hardcoded SunJCE provider

Andrey Turbanov aturbanov at openjdk.org
Mon Oct 21 08:36:10 UTC 2024


On Wed, 16 Oct 2024 18:47:44 GMT, Matthew Donovan <mdonovan at openjdk.org> wrote:

> In this PR, I removed hard-coded security providers and replaced them with a system property, test.provider.name. If the property is not specified, the provider originally used in the test is used:
> 
> Cipher c = Cipher.getInstance("AES/GCM/NoPadding", System.getProperty("test.provider.name", "SunJCE"));

test/jdk/javax/security/auth/login/Configuration/GetInstance.java line 88:

> 86:         // get an instance of JavaLoginConfig from SUN
> 87:         Configuration c = Configuration.getInstance(JAVA_CONFIG, null,
> 88:                 System.getProperty("test.provider.name","SUN"));

Suggestion:

                System.getProperty("test.provider.name", "SUN"));

test/jdk/javax/security/auth/login/Configuration/GetInstance.java line 94:

> 92:         try {
> 93:             c = Configuration.getInstance(JAVA_CONFIG, null,
> 94:                     System.getProperty("test.provider.name","SunRsaSign"));

Suggestion:

                    System.getProperty("test.provider.name", "SunRsaSign"));

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21551#discussion_r1808334456
PR Review Comment: https://git.openjdk.org/jdk/pull/21551#discussion_r1808334626


More information about the serviceability-dev mailing list