RFR: 8202100: Merge vm/share/InMemoryJavaCompiler w/ jdk/test/lib/compiler/InMemoryJavaCompiler

Coleen Phillimore coleenp at openjdk.org
Tue Oct 22 17:28:05 UTC 2024


On Tue, 22 Oct 2024 15:52:27 GMT, Ramkumar Sunderbabu <rsunderbabu at openjdk.org> wrote:

> Merging vm folder's InMemoryJavaCompiler into jdk folder's merge InMemoryJavaCompiler so that maintenance is easy.
> 
> Testing done for
> Tiers 1,2,3
> test/hotspot/jtreg tests

I've occasionally run into this duplication and am happy you're fixing it.

test/lib/jdk/test/lib/compiler/InMemoryJavaCompiler.java line 228:

> 226:     }
> 227: 
> 228:     public static Map<String, byte[]> compile(Map<String, ? extends CharSequence> inputMap) {

Could the tests that use this 'compile' be easily fixed to use the below version of 'compile' so you can delete this too?

-------------

PR Review: https://git.openjdk.org/jdk/pull/21641#pullrequestreview-2385856947
PR Review Comment: https://git.openjdk.org/jdk/pull/21641#discussion_r1811119284


More information about the serviceability-dev mailing list